Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add Abracon ASV SMD oscillator #533

Merged

Conversation

HubertD
Copy link
Contributor

@HubertD HubertD commented Mar 1, 2019

This is my first 3d package pull request.
Please let me know what I can do better to cause minimum work for the liberians!

Source PR: KiCad/kicad-packages3D-source#211
Datasheet: https://abracon.com/Support/PackageDrawing/Oscillators/ASV.PDF

Took some missing measurements from the manufacturer's 3D step model.

asv


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@myfreescalewebpage myfreescalewebpage added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Mar 1, 2019
@Misca1234
Copy link
Collaborator

All measurements looks good, ready for merge

@Shackmeister
You use a method to check if a model is correctly merged, how do you do that ?

@SchrodingersGat
Copy link
Contributor

@Shackmeister I am also interested to hear about this - and whether we can script it using FreeCAD or similar, and integrate into Travis CI

@Misca1234
Copy link
Collaborator

@Shackmeister
You use a method to check if a model is correctly merged, how do you do that ?

@Misca1234 Misca1234 merged commit eb1d0d4 into KiCad:master Jun 1, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Jun 1, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 1, 2019
@easyw
Copy link
Contributor

easyw commented Jun 1, 2019

Hi @Misca1234
It seems that the model is not correctly unioned...

Oscillator_SMD_Abracon_ASV-4Pin_7 0x5 1mm

@Misca1234
Copy link
Collaborator

I tried to load the .FCstd file but could not sort out how it is supposed to be merged,
if you dont want to give a shoot I can remake it with scripts

@easyw
Copy link
Contributor

easyw commented Jun 1, 2019

@Misca1234
what is needed is a union of all the bodies... it can easily done using StepUp and after selecting the Part container, click on the Union button of StepUp...
An other option is delete the Part container and then make a union of Bodies.

simple-copy-of-union
I'm attaching the second option modified FC file
Oscillator_SMD_Abracon_ASV-4Pin_7.0x5.1mm.FCStd.zip

@easyw
Copy link
Contributor

easyw commented Jun 1, 2019

@SchrodingersGat @Shackmeister
is there anything going on about automating these checks (I cannot found where, but I remember that @Shackmeister was going to do something):

  1. the imported object is a single shape (FC needs to have the 'Enable STEP compound' preferences option unchecked to verify this behavior)
  2. the label is corresponding to the file name

@SchrodingersGat at least the need to check the Union for STEP model should be added to the PR checking list...

@Shackmeister
Copy link
Collaborator

@Misca1234 for checking if it's properly merged, I simply open it in FC.
afterwards I run a check using Part workbench -> "Check Geometry".
This has a lot of false positives for imported step models, but works great for models made in CQ/FC.

@easyw @SchrodingersGat I made an issue here: KiCad/kicad-library-utils#291

I have done some of the step checking (see issue above), but I was hoping someone (looking at you @SchrodingersGat ;) ) could turn that into a Travis script.

@Misca1234
Copy link
Collaborator

Ok, I repush it based on easyw's fusion made one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants