Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Travis checks for packages3D #291

Open
Shackmeister opened this issue Mar 17, 2019 · 5 comments
Open

Travis checks for packages3D #291

Shackmeister opened this issue Mar 17, 2019 · 5 comments

Comments

@Shackmeister
Copy link
Collaborator

Hi Everybody

packages3D could definitely benefit from the Travis integration, which has been implemented.
Things which could be worth checking (open for ideas):

  1. If a pair of Step and wrl files has been comitted.

  2. If KSU was used for exporting

  3. If the internal stepname is the same as the external name.

  4. if there is only one object inside the file.

  5. A mechanical/solid check (might still be too unstable)

  6. Material properties.

  7. if the model if referenced anywhere in the footprint repo.

I havent played with any Travis scripting, but thought I would put it here to discuss it.
@Misca1234 @easyw

@Misca1234
Copy link
Collaborator

I am all for it
All tedious checking that is easy to implement as scripts is always good

I guess Travis for KiCad on git is implements as python scripts, like in
https://github.com/KiCad/kicad-library-utils

Perhaps we can place them in
https://github.com/KiCad/kicad-library-utils

and super admins add them to the check in process flow

@poeschlr
Copy link
Collaborator

poeschlr commented Apr 7, 2019

Everyone with write permission should be able to setup travis.

@Shackmeister
Copy link
Collaborator Author

Shackmeister commented May 5, 2019

Hi Guys (@easyw @SchrodingersGat etc)

I made a (slightly crude) python script to check if KSU was used to export, and if the internal name is the same as the filename (very common issue).

This is by no means ready for anything, but can hopefully spark some discussion.
Also I'm a bit uncertain if we should base the scripts around FC/OCC/PYOCC or a handmade parser (what I used)

Step_Check.zip

@easyw
Copy link

easyw commented May 6, 2019

@Shackmeister
checking if the exporting is done by KSU and if the file name is the same of the part name could be checked at simple text level. For KSU this check can be done also on WRL, at text level, adding also a check if wrl materials are used.
I think instead that we need to relay on FC or OCC or PyOCC to check if the part is a single object after importing the step file.
I wouldn't trust too much, finally, on the geometry check... it could be done as an option.

@easyw
Copy link

easyw commented May 6, 2019

@Shackmeister
I've gone through the Step_Check.zip and I've found that you can add the check in OR for:
/* author */ ('kicad StepUp','ksu'), -> script generated file (already covered)
the following:
('kicad StepUp'),('ksu MCAD'), -> manually exported file (to be implemented)
for WRL files it should be enough to check for:
#kicad StepUp wrl exported
and to check if Materials are used, a check to:
appearance Appearance {material DEF could be implemented.
appearance Appearance{material USE could be implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants