Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add SOP-10 and NSOP-16 footprints for HT42B534 #2432

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thatoddmailbox
Copy link
Contributor

@thatoddmailbox thatoddmailbox commented Aug 28, 2020

Add SOP-10 and NSOP-16 footprints for HT42B534

This pull request goes along with KiCad/kicad-symbols#2695, which adds symbols for the HT42B534 USB-UART IC. (datasheet: https://www.holtek.com/documents/10179/11842/HT42B534-xv110.pdf)

Holtek uses slightly different names for some packages, so it was suggested in that PR to add footprints for those packages. Since I couldn't find a way to make an alias for packages, I copied and renamed the existing footprints. You can match the Holtek package drawings to the drawings referenced in the original footprints, and see that the dimensions are all the same.

Package_SO:SSOP-10_3.9x4.9mm_P1.00mm -> Package_SO:SOP-10_3.9x4.9mm_P1.00mm
Package_SO:SOIC-16_3.9x9.9mm_P1.27mm -> Package_SO:NSOP-16_3.9x9.9mm_P1.27mm

Screenshots:
image
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Aug 28, 2020
@myfreescalewebpage
Copy link
Collaborator

@thatoddmailbox is it generated with the footprint generator at https://github.com/pointhi/kicad-footprint-generator/pulls ?
If yes, please provide link to the pull request of the generator. Else, you have to use it to generate these footprints.
Joel

@cpresser cpresser self-assigned this Sep 9, 2020
@cpresser cpresser added Scripting required A scripted version of this contribution is required and removed Pending reviewer A pull request waiting for a reviewer labels Sep 9, 2020
@thatoddmailbox
Copy link
Contributor Author

@myfreescalewebpage They were just copied and renamed from the existing symbols. I have the NSOP-16_3.9x9.9mm_P1.27mm footprint being generated from the script now, and will submit a PR for it, but wanted to ask about the other footprint (SOP-10).

SOP-10_3.9x4.9mm_P1.00mm was copied from SSOP-10_3.9x4.9mm_P1.00mm, which was not originally generated with the script. Should I still add a definition for that or leave it as is? Also, if I do use the script, it wants to just call it P1mm, should I use that name or keep it as P1.00mm to match the original name?

@myfreescalewebpage
Copy link
Collaborator

I think using the script for both is a good enhancement.
Do not modify the existing SSOP name because it will have an impact on the symbols.
Joel

@myfreescalewebpage
Copy link
Collaborator

@thatoddmailbox any news here ?

@myfreescalewebpage
Copy link
Collaborator

No news of the author, indicate this is Abandoned

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 29, 2020
thatoddmailbox added a commit to thatoddmailbox/kicad-footprint-generator that referenced this pull request Sep 29, 2020
…9mm_P1.00mm and NSOP-16_3.9x9.9mm_P1.27mm

see KiCad/kicad-footprints#2432 for explanation
@thatoddmailbox
Copy link
Contributor Author

@myfreescalewebpage Sorry about that! I created pointhi/kicad-footprint-generator#645. Should I update this PR with the output of the generator? Or will it be automatically added to kicad-footprints once the generator PR is merged?

@cpresser
Copy link
Contributor

@myfreescalewebpage I will take care of this PR.

Regarding the name, I suggest to change it. Just 3 symbols need to be fixed:
image

@thatoddmailbox
Copy link
Contributor Author

@cpresser OK, I updated pointhi/kicad-footprint-generator#645 and KiCad/kicad-symbols#2695 to rename the footprint and associated symbols.

@myfreescalewebpage myfreescalewebpage removed the Abandoned Original author has stopped working on the PR label Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Scripting required A scripted version of this contribution is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants