Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulkan subtest for diffCtx and platform/device info #2046

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix vulkan subtest for diffCtx and platform/device info #2046

wants to merge 6 commits into from

Conversation

saurabhnv
Copy link
Contributor

Fixes:

  1. Multi import diff ctx subtest which acquires/releases external memory via queue not associated with the context in which memory was imported.
  2. Platform/Device info subtests to handle different platforms and availability of the query.

@saurabhnv
Fix vulkan platform/device info tests
41a2962 
* Test fails for implementations that do not advertise external
  memory/semaphore extensions, skip such a case.
* Add changes to correctly query the handle types list and skip if not
  supported.
* Add checks to enforce memory import support and semaphore
  import/export support when cl_khr_external_memory and
  cl_khr_external_semaphore are available respectively.
@saurabhnv
Fix buffer multiImport_diffCtx subtest
3b30d71 
Fixes the issue where the subtest incorrectly tries to acquire/release
memory using a command queue associated with a context different from
the one under which the external memory was imported.
@saurabhnv
Use correct ref err code for clReleaseSemaphoreKHR
fa98346
@saurabhnv
Move platform info helper functions to harness
b4c6565
@saurabhnv
Use platform of supplied device for platform_info
843ba0d 
Instead of iterating over all available platform, just
get the platform belonging to the supplied device handle.
bashbaug
bashbaug approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, latest version LGTM.

I'm still unable to choose the platform and device to run on for these tests using the usual mechanisms (e.g. CL_PLATFORM_INDEX), so some additional work is still needed, but this is a definite step in the right direction.

@bashbaug
Copy link
Contributor

bashbaug commented Sep 3, 2024

Discussed in the September 3rd memory subgroup. Waiting a bit longer for a review from Qualcomm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabhnv @bashbaug @nikhiljnv