Add big integer column support #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenjiOhtsuka
requested changes
Feb 11, 2020
src/main/kotlin/com/improve_future/harmonica/core/table/TableBuilder.kt
Outdated
Show resolved
Hide resolved
sylux6
force-pushed
the
long-type
branch
2 times, most recently
from
623f5fb
to
761bf4e
Compare
|
Up |
|
I guess that overloading is a way to accept integer value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for? Why do you create this pull request?
Add long (also known as big integer) column type support #141
What is changed?
New column definition for big integer
Other comment
Some side files have been changed due to my local code style settings I guess. Let me know if it matters or not (should we gitgnore them?)