Skip to content

Commit

Permalink
feat: update envs
Browse files Browse the repository at this point in the history
  • Loading branch information
boodyvo committed Sep 16, 2024
1 parent 9220e53 commit cd9b0d0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
4 changes: 0 additions & 4 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,6 @@ METRIC_PRUNING_ROUTINE_DELAY_FIRST_RUN_SECONDS=5
# from the time the pruning routine runs
# all metrics for earlier days will be truncated
METRIC_PRUNING_MAX_REQUEST_METRICS_HISTORY_DAYS=45
# If we use metric database. If set to false,
# all metric collection and connection to the DB would be disabled
# and the service would run without any metrics.
METRIC_DATABASE_ENABLED=${METRIC_DATABASE_ENABLED}
# CACHE_ENABLED specifies if cache should be enabled. By default cache is disabled.
CACHE_ENABLED=true
# REDIS_ENDPOINT_URL is an url of redis
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/ci-e2e-no-metrics-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ jobs:
- name: build and start proxy service and it's dependencies
# We need to provide additional env file to override the METRIC_DATABASE_ENABLED variable, not via env variable.
# Mentioned here: https://github.com/docker/compose/issues/9737
run: sudo docker compose -f ci.docker-compose.yml up -d --build proxy redis
env:
METRIC_DATABASE_ENABLED: "false"
run: sudo docker compose -f ci.docker-compose.yml --env-file .env --env-file no_metric.env up -d --build proxy redis
- name: wait for proxy service to be running
run: bash ${GITHUB_WORKSPACE}/scripts/wait-for-proxy-service-running.sh
env:
Expand Down
6 changes: 5 additions & 1 deletion no_metric.env
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
##### Local development config
##### Local development config, used for CI to disable metrics

# If we use metric database. If set to false,
# all metric collection and connection to the DB would be disabled
# and the service would run without any metrics
METRIC_DATABASE_ENABLED=false

0 comments on commit cd9b0d0

Please sign in to comment.