Skip to content

Commit

Permalink
feat: add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
boodyvo committed Sep 16, 2024
1 parent 74142d0 commit 46912b6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ METRIC_PRUNING_ROUTINE_DELAY_FIRST_RUN_SECONDS=5
# from the time the pruning routine runs
# all metrics for earlier days will be truncated
METRIC_PRUNING_MAX_REQUEST_METRICS_HISTORY_DAYS=45
# If we use metric database. If set to false,
# all metric collection and connection to the DB would be disabled
# and the service would run without any metrics.
METRIC_DATABASE_ENABLED=${METRIC_DATABASE_ENABLED:-true}
# CACHE_ENABLED specifies if cache should be enabled. By default cache is disabled.
CACHE_ENABLED=true
# REDIS_ENDPOINT_URL is an url of redis
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-e2e-no-metrics-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
- name: pull pre-built images
run: sudo docker compose -f ci.docker-compose.yml pull
- name: build and start proxy service and it's dependencies
# We need to provide additional env file to override the METRIC_DATABASE_ENABLED variable, not via env variable.
# Mentioned here: https://github.com/docker/compose/issues/9737
run: sudo docker compose -f ci.docker-compose.yml --env-file .env --env-file no_metric.env up -d --build proxy redis
run: sudo docker compose -f ci.docker-compose.yml up -d --build proxy redis
env:
METRIC_DATABASE_ENABLED: "false"
- name: wait for proxy service to be running
run: bash ${GITHUB_WORKSPACE}/scripts/wait-for-proxy-service-running.sh
env:
Expand Down
2 changes: 1 addition & 1 deletion ci.docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ services:
EVM_QUERY_SERVICE_URL: https://evmrpc.internal.testnet.proxy.kava.io
# we need the metric to be used from no_metric.env or by default set up as true, so to test the metrics collection.
# doesn't work with the env variable, so need env file. Mentioned here: https://github.com/docker/compose/issues/9737
METRIC_DATABASE_ENABLED: "${METRIC_DATABASE_ENABLED}:-true"
METRIC_DATABASE_ENABLED: "${METRIC_DATABASE_ENABLED}"
ports:
- "${PROXY_HOST_PORT}:${PROXY_CONTAINER_PORT}"
- "${TEST_UNCONFIGURED_PROXY_PORT}:${PROXY_CONTAINER_PORT}"
Expand Down

0 comments on commit 46912b6

Please sign in to comment.