Add custom registered precompiles to the active precompile list #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
active precompile list
nddeluca
commented
Apr 18, 2024
| precompiles = PrecompiledAddressesHomestead | ||
| } | ||
|
|
||
| // TODO: Consider performance improvements here to prevent iteration & allocations on every call. |
nddeluca
requested review from
karzak,
pirtleshell,
drklee3,
evgeniy-scherbina and
Behdad-Kava
nddeluca
commented
Apr 18, 2024
| @@ -151,19 +152,29 @@ func init() { | |||
| } | |||
|
|
|||
| // ActivePrecompiles returns the precompiles enabled with the current configuration. | |||
| func ActivePrecompiles(rules params.Rules) []common.Address { | |||
| func ActivePrecompiles(rules params.Rules) (precompiles []common.Address) { | |||
There was a problem hiding this comment.
Added #23 to track duplicated logic between this file and extended_contracts.go
evgeniy-scherbina
approved these changes
Apr 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* fix: Ensure that registered custom precompiles are returned in the active precompile list * add todo to track dynamic registration vs forcing an init order (cherry picked from commit 031b717) # Conflicts: # core/vm/contracts.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures that all registered custom precompiles that can be called from the state machine are returned in the active list.
Resolves #20