feat!: Enforce stricter validations for genesis accounts and enabled precompiles #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genesis accounts currently serve no purpose for non-contract accounts. Currently, they can exist but code and storage will be empty and therefore has no effect besids ensuring the matching account is subject to similar validations as a contract. This change restrics valid genesis accounts to those with Code only. Storage can still be empty for contracts, as there is no requirement for values to be set in state for all contracts.
Using capital letters for test case names improved readability when reading and parsing.
On some chains running ethermint, a self destruct bug that caused the code for other contract accounts to be deleted would result in exported genesis accounts with empty code. A patch was then added to genesis that allowed the hash check to be skipped in order for these genesis files to be re-imported successfully. This does not affect us contracts on Kava, so this check is being removed.
Since Genesis Accounts may only be contracts, we add the assertion that they must have a positive sequence (eip-155) and that they do not have a public key set. A contract can not be associated with a public key and must have a default nonce set. In addition, since enabled precompiles are contract accounts, we enforce that these have matching genesis accounts to share these validations and in addition, enforce a fixed code.
nddeluca
force-pushed
the
nd-strict-genesis-validations
branch
from
cd02af6
to
b2308ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the assertion that genesis accounts may only be contracts. This means they must have code set, a nonce of 1, and have no public key associated with their x/auth account. This also applies to enabled precompiles, which we also assert has a genesis account with code set to a fixed value.
Changes:
Replaces #65