Resolve CI and test errors #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches kava, suppresses vuln errors
nddeluca
reviewed
Feb 2, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -196,8 +196,8 @@ | |||
| // Get bip39 mnemonic | |||
| var mnemonic, bip39Passphrase string | |||
|
|
|||
| recover, _ := cmd.Flags().GetBool(flagRecover) | |||
| if recover { | |||
| shouldRecover, _ := cmd.Flags().GetBool(flagRecover) | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
Avoid large diff and keep it the same for now
nddeluca
approved these changes
Feb 8, 2024
evgeniy-scherbina
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Remove depguard from golangci-lint * Remove cachix/cachix-action step in integration_tests job * Remove cachix/cachix-action step from gomod2nix * Remove cachix/cachix-action step from python-lint * Remove cache upload job * Trigger ci tests * Use go 1.20 for iavl v1 * Use go 1.20 in ci * Fix yaml parsing 1.20 * Resolve lint issues * Update ibc-go to v6.1.1, [email protected] Matches kava, suppresses vuln errors * Exclude .pb.go from lll linter * Resolve unused lint errors * Add get-diff-action step to integration tests * Update integration_tests nix setup * Add nix-community/cache-nix-action for integration tests * test: Fix tracing tests mock error * ci: Remove codecov upload * Add goleveldb replace directive to fix version not found errors in test-rpc * Use json string instead of byte array for tests data clarity * Ignore lint lll error on server.FlagAPISwagger * Resolve lint errors * fix: tx trace gasUsed camel case instead of snake * Prevent modifying trace response if missing fail or non gas error * Add note for tracing test * Revert tracing changes with minimum fix Avoid large diff and keep it the same for now * gofumpt * test: Update test_pruned_node expected error integration test * Handle connection refused error in integration test * Restore jose2go version in gomod2nix.toml * Resolve flake8 lint errors on integration tests * Add -I nixpkgs=./nix to integration Makefile
nddeluca
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Resolve CI and test errors (#34) * Remove depguard from golangci-lint * Remove cachix/cachix-action step in integration_tests job * Remove cachix/cachix-action step from gomod2nix * Remove cachix/cachix-action step from python-lint * Remove cache upload job * Trigger ci tests * Use go 1.20 for iavl v1 * Use go 1.20 in ci * Fix yaml parsing 1.20 * Resolve lint issues * Update ibc-go to v6.1.1, [email protected] Matches kava, suppresses vuln errors * Exclude .pb.go from lll linter * Resolve unused lint errors * Add get-diff-action step to integration tests * Update integration_tests nix setup * Add nix-community/cache-nix-action for integration tests * test: Fix tracing tests mock error * ci: Remove codecov upload * Add goleveldb replace directive to fix version not found errors in test-rpc * Use json string instead of byte array for tests data clarity * Ignore lint lll error on server.FlagAPISwagger * Resolve lint errors * fix: tx trace gasUsed camel case instead of snake * Prevent modifying trace response if missing fail or non gas error * Add note for tracing test * Revert tracing changes with minimum fix Avoid large diff and keep it the same for now * gofumpt * test: Update test_pruned_node expected error integration test * Handle connection refused error in integration test * Restore jose2go version in gomod2nix.toml * Resolve flake8 lint errors on integration tests * Add -I nixpkgs=./nix to integration Makefile * Fix integration-tests CI job * Update ethermint dependency in upgrade-test-package.nix * Fix golang linter errors * Fix python linter errors * Fix gomod2nix CI job * Temporary disable Dependency Review job --------- Co-authored-by: drklee3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One vuln check failing with
github.com/dvsekhvalnov/jose2goignoring for later update.