Revert use of IAVL V1 & retract v0.47.10-kava.2 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The branch `kava-v0.47.10-release-x` should only ever use iavl v0. Use of IAVL v1 should be performed on branch `kava-release-v0.47.10-iavl-v1`.
the release incorrectly upgrades to iavl v1
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| hash := st.tree.Hash() | ||
| hash, err := st.tree.Hash() | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
drklee3
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch
kava-v0.47.10-release-xshould only ever use iavl v0.Use of IAVL v1 should be performed on branch
kava-release-v0.47.10-iavl-v1Reverts the commits that switched to iavl v1. Added a retraction of
v0.47.10-kava.2to the go mod.