merge backported cosmos-sdk upgrade to iavl v1 to kava's v47 fork #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galxy25
commented
Mar 5, 2024
galxy25
commented
- reference commit backported from cosmos-sdk v50 to v46
- verified all unit tests pass (minus the expected failures that exist upstream, but none of those are related to the updated store module)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| func ConvertCommitmentProof(proof *cics23.CommitmentProof) *ics23.CommitmentProof { | ||
| msg, _ := proto.Marshal(proof) | ||
| var newProof ics23.CommitmentProof | ||
| proto.Unmarshal(msg, &newProof) |
Check warning
Code scanning / Golang security checks by gosec
Errors unhandled. Warning
galxy25
requested review from
DracoLi,
rhuairahrighairidh,
pirtleshell,
drklee3 and
evgeniy-scherbina
nddeluca
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.