Fixes #37876 - add leading slash to /subscriptions/add #11167
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Add a leading slash to the "Add Subscriptions" button that shows on the Subscriptions page when your manifest is empty. This will prevent the button from leading to
/subscriptions/add/subscriptions/addwhich causes a blank screen.Considerations taken when implementing this change?
Apparently it's been like this since the button was introduced in #10440 and no one noticed.
What are the testing steps for this pull request?
Import a manifest with no subscriptions in it
Go to the Subscriptions page
There are two "Add Subscriptions" buttons. We are concerned with the big one in the center (the PF4 one)
Click the button - you should go to the add subscriptions page
Now click Back
and click the button again.
Before - You are directed to
/subscriptions/add/subscriptions/add, leaving React Router with nothing to render. 😢After - You are correctly directed to
/subscriptions/addevery time, even after navigating back from the Add Subscriptions page.