Fixes #37853 - Add OSTree remote option depth

[lumarel]

What are the changes introduced in this pull request?

This PR adds the generic_remote_option depth to the OSTree repository type.

Considerations taken when implementing this change?

I checked if the missing number types for the generic remotes is already available somewhere, and tried to keep the form the same.
The number type in the new-repository form has set a minimum value of 0, I am still not sure if this is the best place for that, but I also didn't want to add new variables as this might have been a serious undertaking for me, to get a new variable into the generic_remote_option function.

What are the testing steps for this pull request?

I have a testsystem setup on Foreman 3.11, where I edited the source, including version upgrade tests.

[ianballou]

Thanks for the contribution!
Noticed one quick thing:

[ianballou]

Later in the file there's the line:

test_url_root_options generic_remote_options: {include_refs: ['rawhide']}.to_json

What if you changed it to:

test_url_root_options generic_remote_options: {include_refs: ['rawhide'], depth: 1}.to_json

or something like that? That way, the test in test/services/katello/pulp3/repository_integration_test.rb I think would pick it up and test the new parameter.

I'm going off of some assumptions since I haven't looked at generic content types for a while, but it's worth checking for more test coverage.

[lumarel]

Okay thanks for the review, lets see if there is really a VCR change necessary now, after the test addition 🙂

[ianballou]

I just tested the PR, it's looking fine. I verified the depth is getting set on the Pulp remote:

...
    }
  ],
  "depth": 1,
  "include_refs": [],
  "exclude_refs": []
...

I also see the option to set the depth in hammer:

 --deb-releases VALUE                           Whitespace-separated list of releases to be synced from deb-archive
 --depth NUMBER                                 An option to specify how many commits to traverse.
 --description VALUE  

[ianballou]

Looks like you just need to:

mode=all ktest katello/test/services/katello/pulp3/repository_integration_test.rb

and upload the new VCRs.

[ianballou]

Looking good, thank you!