Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37794 - Stub pulp-deb backend data call during API test #11137

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Sep 11, 2024

What are the changes introduced in this pull request?

Stub a pulp call during API test

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Tests green? Although we have some unrelated zeitwerk errors which will be fixed by this: #10997

@sjha4
Copy link
Member Author

sjha4 commented Sep 11, 2024

That zeitwerk PR is merged so we should be able to isolate errors on this one..

@sjha4 sjha4 changed the title Refs #37794 - Stub backend data call during tests Refs #37794 - Stub pulp-deb backend data call during tests Sep 11, 2024
@sjha4 sjha4 changed the title Refs #37794 - Stub pulp-deb backend data call during tests Refs #37794 - Stub pulp-deb backend data call during API test Sep 11, 2024
Copy link
Contributor

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid my review is not the one you need, but I will approve this anyway as a signal to others. I believe we broke the tests on master and this fixes them. Thanks a bunch!

@jeremylenz
Copy link
Member

Thanks @sjha4 @quba42! 🍏

@jeremylenz jeremylenz merged commit bcc75d9 into Katello:master Sep 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants