Fixes #37795 - set multiple Content Views via a single Activation key

[parthaa]

What are the changes introduced in this pull request?

• Can add multiple content view environments to Activation Keys.
• Can have a host register to multiple content view environments via Activation Key
• Can have a host register to a composite of Activation Keys
• API bindings to see information about the content view environments
• API bindings to set the content view environments
• Adds Content View Environment Activation Keys mapping table to manage multiple CVEs for an AK.

Considerations taken when implementing this change?

The approach largely mirrors what we did for content facets except 2 important changes

• If you have the multi cv setting on and you specified multiple activation key on host registration, the CVEs of each individual activation key will get added. If you have the setting off, the behavior will be the same as status quo - only the cve of the last activation key will be added.
• Prior to migration if you have an activation key where only the lce environment was set and content view was blank, the migrator will ignore creating CVEs for those environments. The Activation Key will be associated to no content view environment (this could be useful if you are creating activation keys with system purpose attributes.)

What are the testing steps for this pull request?

1. Create a few activation keys
2. Check out the PR and run the migration
3. Verify things migrated correctly.
4. You should then be able to use hammer activation-key create --name=foo --organization-id=1 --content-view-environments='env_label1/cv_label1,env_label2/cv_label2'
5. You can verify activation key foo has 2 content view environments on rails console
6. Try registering a host to to this activation key via global registration.
7. You should notice repositories from env1/cv1 and env2/cv2 in the redhat repos file.
8. Try testing things like deleting content views and have it reassigned to something else etc.

[jeremylenz]

thanks @parthaa!

Some initial code comments

Also tested a bit and found that when I use the Angular page to edit syspurpose values on an AK, multiple CVEs are overwritten. This does not happen with the new React AK page.

[jeremylenz]

As discussed please change the logic here so that

if the AK doesn't have CV or LCE, don't add it. (AKs aren't required to have cv/lce.)
if the AK has only CV, add it as Default LCE and that CV (and add a warning in the docs)
if the AK has only LCE, add it as Default LCE / Default Org View
if the AK has both, great, add that CVE

[parthaa]

Should be addressed in the latest commit

[parthaa]

Those CVEs should be part of the aks_with_no_cve + aks_with_missing_cve list. Seems to be ok to me? I am I missing something?

[jeremylenz]

Did some more testing

Global Reg with multiple AKs works as expected:

1. Multiple AKs' CVEs are combined
2. Ordering of CVEs is preserved between multiple AKs

Available Releases works as expected (Release version dropdown on AK details shows release versions from the AK's repositories)

[jeremylenz]

I guess the only one I don't see covered is

if the AK has only CV, add it as Default LCE and that CV (and add a warning in the docs)

Right now it would get Library/Default Org View.

[jeremylenz]

1. need to rebase now that Zeitwerk is merged
2. In config/initializers/inflections.rb, need to add

'cveak_migrator' => 'CVEAKMigrator',

in the first section

[jeremylenz]

Ruby test failures related, should be easy fixes
React test failures unrelated, due to jsx-eslint/eslint-plugin-react#3819

[jeremylenz]

== 20240730163043 AddContentViewEnvironmentActivationKey: reverting ===========
-- add_column(:katello_activation_keys, :content_view_id, :integer, {:index=>true})
   -> 0.0010s
-- add_column(:katello_activation_keys, :environment_id, :integer, {:index=>true})
   -> 0.0004s
-- add_foreign_key("katello_activation_keys", "katello_content_views", {:name=>"katello_activation_keys_content_view_id", :column=>"content_view_id"})
   -> 0.0011s
-- add_foreign_key("katello_activation_keys", "katello_environments", {:name=>"katello_activation_keys_environment_id", :column=>"environment_id"})
   -> 0.0010s
rails aborted!
StandardError: An error has occurred, this and all later migrations canceled:

PG::UndefinedColumn: ERROR:  column "priority" does not exist
LINE 1: ...ontent_view_environment_activation_keys" ORDER BY "priority"...

I got this when trying to run the down migration. Seems it happens at about this point. The down migration erasing the "priority" column has already run at this point.

[parthaa]

Updated

[jeremylenz]

Let's take it for a real spin now!

🚀