Fixes #36540 - Accurately checks custom product enablement upgrade task #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for Issue #36120 changed behavior of custom repos. By default all custom repos got disabled in candlepin. However a migration task was provided to add overrides for existing custom repos. This commit checks if there are any custom product content who's enablement is set to true. This implies that upgrade rake task update_custom_products_enablement has not run and hence the task can be run.
|
Issues: #36540 |
|
Moved it to #10644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
This commit tries to address the issues listed here
PR for Issue #36120 changed default enablement for custom repos. By default all custom repos got disabled in candlepin. However a migration task was provided to add overrides for existing custom repos.
We needed a way for the custom product enablement upgrade task to only run if needed without having to rely on
UpgradeTask.needing_runThis commit checks if there are any custom product content who's enablement is set to true. This implies that upgrade rake task update_custom_products_enablement has not run and hence the task can be run.
Considerations taken when implementing this change?
Multiple approaches were thought of but the current product enablement check makes the most sense
What are the testing steps for this pull request?
bundle exec rake katello:upgrades:4.9:update_custom_products_enablementshould not change the enablement of anything.bundle exec rake katello:upgrades:4.9:update_custom_products_enablementshould now run and change the enablement of of the repo to false