Skip to content

Commit

Permalink
Fixes #37517 - Upgrade theforeman-rubocop gem to the v0.1.0
Browse files Browse the repository at this point in the history
Choose to inherit `lenient.yml` from `theforeman-rubocop` style, because
that it matches to the rubocop style this repo follows.

Also dropped `Rails` and `Style/Documentation` cops because that already
exist in the lenient style we now follow.
  • Loading branch information
archanaserver committed Jul 23, 2024
1 parent ecaf9c9 commit 7efa86e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
rubocop:
name: Rubocop
uses: theforeman/actions/.github/workflows/rubocop.yml@v0
with:
command: bundle exec rubocop --parallel --format github

test:
name: Ruby
Expand Down
13 changes: 3 additions & 10 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
require:
- rubocop-performance
- rubocop-rails
- rubocop-minitest

# TODO: Remove the following once the rules in the file is addressed
inherit_from:
- .rubocop_todo.yml
# end TODO

Rails:
Enabled: true
inherit_gem:
theforeman-rubocop:
- lenient.yml

Rails/ContentTag:
Enabled: false
Expand Down Expand Up @@ -88,9 +84,6 @@ Style/RedundantSelf:
Style/RedundantReturn:
Enabled: false

Style/Documentation:
Enabled: false # don't require documentation

Style/Encoding:
Enabled: false # don't require utf-8 encoding on every file

Expand Down
2 changes: 1 addition & 1 deletion gemfile.d/test.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
group :test do
gem "vcr", "~> 6.1"
gem 'theforeman-rubocop', '~> 0.0.6', require: false
gem 'theforeman-rubocop', '~> 0.1.0', require: false
end

0 comments on commit 7efa86e

Please sign in to comment.