Don't turn off BTRV after the lowest setpoint temperatur is reached (ex. window was opened) #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
After an open window was closed, the BTRVs HVACMode often changes to the OFF state, which lead to cold rooms
Changes:
_new_heating_setpoint
is the real TRVs lowest temperature:better_thermostat/custom_components/better_thermostat/events/trv.py
Lines 204 to 209 in 6a349d9
I'm not sure for what these lines are for. When the window is opened, the real TRV is automatically set to the lowest temp. Then, through these lines, the BTRV is turned off.
Don't know why the BTRV is controlled here? Maybe to reflect such changes to the UI, or is there a specific reason?
If it was for the UI feedback, then these lines make a bit sense, as the BTRV would be set back to HEAT, if
_new_heating_setpoint
goes back to a higher temperature. But then the issue here is, that this statement is never reached again, as its blocked by this if statementbetter_thermostat/custom_components/better_thermostat/events/trv.py
Line 160 in 6a349d9
So if there wasn't a real need for this kind of behavior, my changes should be enough.
Otherwise I think the logic must be fixed, so statement is reached again that turnes the BTRVs HVACMode back to HEAT. But in my opinion, it could still lead to more problems, if BTRV controls it's own HVACMode.
Related issue (check one):
Checklist (check one):
Test-Hardware list (for code changes)
Debian 11 VM 4GB and devcontainers according to CONTRIBUTION.md
HA Version: 2024.9.1
Zigbee2MQTT Version: 1.40.1-1
TRV Hardware: TS0601 (BRT-100-TRV)
New device mappings
climate.py