Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #98

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Small fixes #98

merged 7 commits into from
Jan 4, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Jan 1, 2024

  • Fixes an issue with using argmax(f, domain) which is not defined in versions below 1.7
  • Temporarily restricts TensorOperations to not be version 4.0.8 as this breaks @planar

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fb9d67) 80.39% compared to head (5fdd659) 80.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   80.39%   80.57%   +0.18%     
==========================================
  Files          42       42              
  Lines        5432     5453      +21     
==========================================
+ Hits         4367     4394      +27     
+ Misses       1065     1059       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jutho
Copy link
Owner

Jutho commented Jan 3, 2024

Looks good, although it seems one AD test still did not pass on Julia 1.6. But it seems an accuracy issue again, at least all the values that are printed seem to match with a large number of significant digits.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Jan 3, 2024

I'll keep playing around a bit to see if I can get it to behave, it's probably not that important, but the green check is nice

@Jutho
Copy link
Owner

Jutho commented Jan 3, 2024

Especially since this will affect all further CI runs once merged.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there.a reason to reorganise the position of weakdeps and extensions in the Project.toml? I thought Aqua made me make exactly the opposite move in TensorOperations.jl

@Jutho
Copy link
Owner

Jutho commented Jan 4, 2024

Ok I'll merge this and revert Project.toml changes in the final commits to #95

@Jutho Jutho merged commit bb2b4cf into master Jan 4, 2024
13 checks passed
@lkdvos lkdvos deleted the ld/argmax branch January 4, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants