Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility and Quality of life for VectorSpaces #120

Merged
merged 9 commits into from
May 8, 2024
Merged

Utility and Quality of life for VectorSpaces #120

merged 9 commits into from
May 8, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented May 5, 2024

This PR adds some missing constructors for ComplexSpace and CartesianSpace with generators, and refactors some small pieces of code that were being used for permuting and manipulating spaces to be in one place.

Additionally, it cleans up some of the space checks, and adds missing @inbounds annotations for the add_***_kernels, which avoids a couple hash calls in the getindex for the fusion trees I think.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.44%. Comparing base (370dd92) to head (424d4fe).

Files Patch % Lines
src/tensors/indexmanipulations.jl 72.72% 3 Missing ⚠️
src/spaces/cartesianspace.jl 0.00% 1 Missing ⚠️
src/spaces/complexspace.jl 0.00% 1 Missing ⚠️
src/spaces/vectorspaces.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   81.46%   81.44%   -0.02%     
==========================================
  Files          42       42              
  Lines        5588     5588              
==========================================
- Hits         4552     4551       -1     
- Misses       1036     1037       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/spaces/homspace.jl Outdated Show resolved Hide resolved
@Jutho Jutho merged commit 79c2ae0 into master May 8, 2024
13 of 14 checks passed
@lkdvos lkdvos deleted the ld-spaces branch September 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants