Fix TensorMap constructor for symmetric tensor from dense matrix (#144

) * Fix tensormap constructor from matrix * Fix tests
Jutho · Aug 12, 2024 · 0a93955 · 0a93955
1 parent fc34907
commit 0a93955
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/tensors/tensor.jl b/src/tensors/tensor.jl
@@ -400,9 +400,10 @@ function TensorMap(data::DenseArray, V::TensorMapSpace{S,N₁,N₂};
     end
 
     t = TensorMap{eltype(data)}(undef, codom, dom)
-    project_symmetric!(t, data)
+    data2 = reshape(data, (dims(codom)..., dims(dom)...))
+    project_symmetric!(t, data2)
 
-    if !isapprox(data, convert(Array, t); atol=tol)
+    if !isapprox(data2, convert(Array, t); atol=tol)
         throw(ArgumentError("Data has non-zero elements at incompatible positions"))
     end
 

diff --git a/test/tensors.jl b/test/tensors.jl
@@ -115,6 +115,9 @@ for V in spacelist
                     end
                     a = @constinferred convert(Array, t)
                     @test t ≈ @constinferred TensorMap(a, W)
+                    # also test if input is matrix
+                    a2 = reshape(a, prod(dim, codomain(t)), prod(dim, domain(t)))
+                    @test t ≈ @constinferred TensorMap(a2, codomain(t), domain(t))
                 end
             end
         end