new glm_predictive_distribution and corresponding changes in LaplaceRedux.predict #99
Conversation
…ase to laplaceredux.predict
CHANGELOG.md
Outdated
| @@ -6,6 +6,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | |||
|
|
|||
| *Note*: We try to adhere to these practices as of version [v0.2.1]. | |||
|
|
|||
|
|
|||
| ## Version [0.3.0] - 2024-07-16 | |||
There was a problem hiding this comment.
Just set this to [1.0.0] also then it's good to go
There was a problem hiding this comment.
Just set this to
[1.0.0]also then it's good to go
the version in the changelog must correspond tot he number in the project.toml?
There was a problem hiding this comment.
Yes, exactly, there are supposed to be linked to each other to make it easy for people to understand what's been changed/added/deleted in specific releases.
Fixed version number.
|
@pat-alt brah! what happened? i only changed a number! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 94.95% 95.27% +0.32%
==========================================
Files 21 21
Lines 575 593 +18
==========================================
+ Hits 546 565 +19
+ Misses 29 28 -1 ☔ View full report in Codecov by Sentry. |
…had a vector of normal distributions, while for classifications we had a matrix of distributions. now it's matrices for both. added unit tests
|
@pat-alt @MojiFarmanbar i tried to cover all the new cases but since there are a lot of ifs i had to add multiple tests. |
|
@MojiFarmanbar do you want to have a quick look as well or should we merge this? |
|
@pat-alt i had a quick look, if you approve it then i would say let's merge it. |
this pull request add the following things:
-part of the gsoc (2024)