Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some unnecessary string overloads #77

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

KristofferC
Copy link
Member

This removes the following invalidations:

julia> using SnoopCompile;

julia> invalidations = @snoopr using InlineStrings;

inserting string(a::Union{Char, SubString{String}, String}, b::Union{Char, SubString{String}, String}, c::InlineString) @ InlineStrings ~/.julia/packages/InlineStrings/xUsry/src/InlineStrings.jl:620 invalidated:
   backedges: 1: superseding string(xs...) @ Base strings/io.jl:189 with MethodInstance for string(::Char, ::Vararg{Any}) (1 children)
              2: superseding string(xs...) @ Base strings/io.jl:189 with MethodInstance for string(::Any, ::Char, ::Any) (12 children)
              3: superseding string(xs...) @ Base strings/io.jl:189 with MethodInstance for string(::Any, ::String, ::Any) (13 children)
              4: superseding string(xs...) @ Base strings/io.jl:189 with MethodInstance for string(::String, ::String, ::Any) (80 children)
              5: superseding string(xs...) @ Base strings/io.jl:189 with MethodInstance for string(::String, ::String, ::Vararg{Any}) (461 children)
   6 mt_cache

Fixes KristofferC/OhMyREPL.jl#361

@KristofferC
Copy link
Member Author

A bit ironic that the invalidation CI fails when it reports:

Run echo "Invalidations on default branch: 237 (237 via deps)" >> $GITHUB_STEP_SUMMARY
  echo "Invalidations on default branch: [2](https://github.com/JuliaStrings/InlineStrings.jl/actions/runs/9905946948/job/27372841502?pr=78#step:9:2)37 (237 via deps)" >> $GITHUB_STEP_SUMMARY
  echo "This branch: 44 (44 via deps)" >> $GITHUB_STEP_SUMMARY

@ararslan ararslan merged commit d54fa1b into JuliaStrings:main Jul 12, 2024
6 checks passed
@KristofferC KristofferC deleted the kc/remove_invalids branch July 23, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant input lag after using InlineStrings
2 participants