Fix startswith/endswith for Julia 1.10 #68
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 93.07% 92.95% -0.13%
==========================================
Files 2 2
Lines 679 681 +2
==========================================
+ Hits 632 633 +1
- Misses 47 48 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/InlineStrings.jl
Outdated
| @@ -693,6 +695,8 @@ function Base.startswith(a::T, b::Union{String, SubString{String}, InlineString} | |||
| end | |||
| end | |||
|
|
|||
| #TODO: optimize this | |||
| Base.endswith(a::InlineString, b::InlineString) = invoke(endswith, Tuple{AbstractString, AbstractString}, a, b) | |||
| function Base.endswith(a::T, b::Union{String, SubString{String}, InlineString}) where {T <: InlineString} | |||
There was a problem hiding this comment.
you left InlineString in the signature here (but you dropped it in line 684).
BTW: why invoking generic function if both strings are InlineString is required?
There was a problem hiding this comment.
Ah, good catch. We were relying on the Base implementation of _memcmp, but it changed in 1.10 and isn't compatible with InlineStrings, so we can just dispatch to the (slightly slower) AbstractString fallback to not be broken on 1.10 for now.
We were relying on the Base implementation of _memcmp, but it changed in 1.10 and isn't compatible with InlineStrings, so we can just dispatch to the (slightly slower) AbstractString fallback to not be broken on 1.10 for now.
JuliaLang/julia@f8dd16e#r118957569