forgot signature + add tests

JuliaStats · Jun 9, 2023 · f352518 · f352518
1 parent 05aec8c
commit f352518
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Loess.jl b/src/Loess.jl
@@ -136,7 +136,7 @@ function loess(
         ]
     end
 
-    LoessModel(xs, ys, predictions_and_gradients, kdtree)
+    LoessModel(convert(Matrix{T}, xs), convert(Vector{T}, ys), predictions_and_gradients, kdtree)
 end
 
 loess(xs::AbstractVector{T}, ys::AbstractVector{T}; kwargs...) where {T<:AbstractFloat} =

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -25,6 +25,12 @@ using RDatasets
     @test Loess.predict(model,x) ≈ y
 end
 
+@testset "reshaped views" begin
+    # See: https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/462
+    # and: https://github.com/JuliaStats/Loess.jl/pull/70
+    @test Loess.loess(reshape(view(rand(4), 1:4), (4, 1)), rand(4)) isa Loess.LoessModel
+end
+
 @testset "sine" begin
     x = 1:10
     y = sin.(1:10)