Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new examples #57

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

samuel-esp
Copy link

@samuel-esp samuel-esp commented Sep 12, 2021

new examples added, new files could still contain some print statements used to test the algorithms

@rayegun
Copy link
Member

rayegun commented Oct 31, 2021

Sorry I lost track of this. If you're still interested in this would you mind doing a couple things for me?

  1. Adding one or two tests for each algorithm
  2. Adding a link to the paper/wikipedia/etc.

If not I will of course finish these up and merge once I have the time to test them :).

One of the changes I just made requires a change to master (which I overlooked previously) which I will do in a moment.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #57 (f3b3900) into master (90ab8e7) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   24.55%   24.92%   +0.36%     
==========================================
  Files          44       45       +1     
  Lines        4471     4546      +75     
==========================================
+ Hits         1098     1133      +35     
- Misses       3373     3413      +40     
Impacted Files Coverage Δ
src/options.jl 27.02% <0.00%> (-6.31%) ⬇️
src/export.jl 37.64% <0.00%> (-1.86%) ⬇️
src/chainrules/constructorrules.jl 54.00% <0.00%> (-0.84%) ⬇️
src/types.jl 100.00% <0.00%> (ø)
src/SuiteSparseGraphBLAS.jl 87.50% <0.00%> (ø)
src/chainrules/maprules.jl 15.38% <0.00%> (ø)
src/lib/LibGraphBLAS.jl 14.88% <0.00%> (+0.15%) ⬆️
src/operations/map.jl 64.06% <0.00%> (+2.15%) ⬆️
src/operators/oplist.jl 10.04% <0.00%> (+2.28%) ⬆️
src/operations/broadcasts.jl 39.06% <0.00%> (+4.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ab8e7...f3b3900. Read the comment docs.

@samuel-esp
Copy link
Author

No worries! I have some tests ready on my other repository, just give some days that I'm currently busy with midterms and i'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants