Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractSparseMatrixCSR interface baseline #546

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

termi-official
Copy link

CSR interface for #538 . Don't mind the typo in the branch name and commit.

TODOs

  • Increase test coverage
  • Docs
  • Decide what to export

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 33.39623% with 353 lines in your changes missing coverage. Please review.

Project coverage is 81.33%. Comparing base (95fd7ff) to head (9f3b51e).

Files Patch % Lines
src/sparseconvert.jl 4.22% 136 Missing ⚠️
src/linalg.jl 35.67% 110 Missing ⚠️
src/sparsematrix.jl 50.69% 107 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   84.12%   81.33%   -2.80%     
==========================================
  Files          12       12              
  Lines        9110     9618     +508     
==========================================
+ Hits         7664     7823     +159     
- Misses       1446     1795     +349     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant