Fix system comparison edge case (#79)

JuliaMolSim · Aug 10, 2023 · a0633ff · a0633ff · mfherbst · Aug 10, 2023
1 parent 9c43870
commit a0633ff
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/lib/AtomsBaseTesting/Project.toml b/lib/AtomsBaseTesting/Project.toml
@@ -1,7 +1,7 @@
 name = "AtomsBaseTesting"
 uuid = "ed7c10db-df7e-4efa-a7be-4f4190f7f227"
 authors = ["JuliaMolSim community"]
-version = "0.1.1"
+version = "0.1.2"
 
 [deps]
 AtomsBase = "a963bdd2-2df7-4f54-a1ee-49d51e6be12a"

diff --git a/lib/AtomsBaseTesting/src/AtomsBaseTesting.jl b/lib/AtomsBaseTesting/src/AtomsBaseTesting.jl
@@ -80,6 +80,7 @@ function test_approx_eq(s::AbstractSystem, t::AbstractSystem;
             @test haskey(s, prop) == haskey(t, prop)
             continue
         end
+        (haskey(s, prop) && haskey(t, prop)) || continue
 
         if s[prop] isa Quantity
             @test rnorm(s[prop], t[prop]) < rtol

diff --git a/lib/AtomsBaseTesting/test/runtests.jl b/lib/AtomsBaseTesting/test/runtests.jl
@@ -86,5 +86,10 @@ include("testmacros.jl")
         @testpass test_approx_eq(system, system_edit; common_only=true)
     end
 
+    @testset "Identical systems without multiplicity" begin
+        case = make_test_system(; drop_sysprop=[:multiplicity])
+        @testpass test_approx_eq(case.system, case.system)
+    end
+
     # TODO More tests would be useful
 end