Move Examples. #331
Merged
Move Examples. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2023
…tangeling them here further.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
- Coverage 99.74% 99.65% -0.09%
==========================================
Files 79 69 -10
Lines 7353 6337 -1016
==========================================
- Hits 7334 6315 -1019
- Misses 19 22 +3 ☔ View full report in Codecov by Sentry. |
kellertuer
added
the
Ready-for-Review
|
The reduction in global code coverage is unavoidable, since we reduced the code base but did not cover any of the 19 not yet covered lines. Besides this remark all is working and ready-to-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves functions that formerly were used in examples to
ManoptExamples.jlto reintroduce these old examples over there as well.While formally this might be considered breaking, I would assume that these functions were actually unused since we abandoned the old examples a year ago when releasing Manopt 0.4.
Still all removed functions will be carefully documented in the changelog and the test suite cases / files will also move over.
This resolves one of the points in #297.
This PR is accompanied by the corresponding PRs in
ManifoldDiff(JuliaManifolds/ManifoldDiff.jl#37) andManoptExamples.jl(JuliaManifolds/ManoptExamples.jl#12).