-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add segre and warped segre manifold #755
base: master
Are you sure you want to change the base?
Conversation
Thanks for getting this started! A very short first look
|
Thanks, you should now be added as a collaborator to the fork. I'll take a look at the doc stuff and try to conform to the rest of the repo. For the testing, I never figured out how to run the tests locally so I just commited my best guess. But once tests run, they should at least guarantee that the methods that Segre implements are consistent with each other. |
No worries! Some parts of such a PR are a bit involved. I will both set up the tests for you and help you running them locally :) |
Hi again, |
HI, Locally on your machine you have to set the package into development mode and then call The development mode is maybe the tricky one (see https://pkgdocs.julialang.org/v1/managing-packages/#developing), running from shell should be a bit easier. We wrote the docs in its own environment so that should work fine. If you can not get it to run you could post the error message here or we can check (after I found time) in a video call. |
Thanks, I'll try those things. No stress! |
Thanks for the contribution! I see there is an error with an unrelated test, I will fix it soon in a separate PR. |
I allowed myself to fix a few small things here
What would be great
Besides all these comments – super cool that you got this started! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
==========================================
- Coverage 96.38% 94.23% -2.16%
==========================================
Files 123 125 +2
Lines 11438 11700 +262
==========================================
Hits 11025 11025
- Misses 413 675 +262 ☔ View full report in Codecov by Sentry. |
Thanks for fixing those things! The problem is indeed a rename of AlphaWarpedMetric. I still don't know if the current name, WarpedMetric, is a good choice. The problem is that the euclidean metric is already a warped product metric, but then you can have a whole family of metrics based on your warping parameter and most of those are not euclidean... Sorry, I still can't find where to view the documentation. |
Ah it might be that as an external PR-opener this does not give you push rights, so the preview button does not appear, I have to check. For the name, try to find a name that fits well. For me |
I shall meditate on the name for today and tomorrow, otherwise let's just go with WarpedMetric. I also tried running make.jl but I get the following error:
|
Oh, sorry! I forgot about the (bit involved) Quarto examples. You either have to install Quarto (and add Sorry forgot about those nitty gritty details. And sure, for best of cases we should come up with something that “just works”, but for now rendering Quarto with pure Julia is still not yet there (and we would depend on that). |
No worries! Sorry for bothering you when you said you were busy, I just wanted to be able to see the docs so that I could work on them in the meantime. I get the same error again with |
Ah, hm, yes. That comes from “I am busy but I can answer this in 2 minutes so let's just do it”-answers (mine, not yours). What I wrote does hold for Manopt.jl, but not yet for Manifolds.jl (but then we should introduce this soon!) – so then, sorry, you would have to run first with |
I got it to work now by commenting out lines 109-114 in make.jl:
Thanks for the help! Now I'll try to write a nice documentation page like the ones for the Stiefel etc :) |
Ah, yeah, the ARG I also got you started already on such a page, see |
I see the segre.md that you added, very nice! I also see some texing errors that I made along the way. Thanks! |
No description provided.