Towards integration on manifolds #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbaran
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
========================================
Coverage 99.20% 99.21%
========================================
Files 106 106
Lines 10215 10340 +125
========================================
+ Hits 10134 10259 +125
Misses 81 81
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mateuszbaran
added
Ready-for-Review
kellertuer
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Here is two more remarks.
In general this is missing 4 lines of coverage, that would be nice to check.
I do not understand the theory here completely, but noticed that already quite a while ago I checked most files as “viewed” - so I think past-me found them ok.
So besides test coverage, this is fine I think.
Co-authored-by: Ronny Bergmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started some work on integration on manifolds, mostly with exponential-wrapped distributions and kernel density estimation in mind. It is primarily inspired by http://arxiv.org/abs/2009.01983 . @sethaxen I think the
volume_densityfunction may be interesting for you 🙂 . It connects integration on a manifold with integration in normal coordinates.