Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume that SubString has pointer and copy instead #506

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Don't assume that SubString has pointer and copy instead #506

wants to merge 5 commits into from
+13 −2

Conversation

LilithHafner
Copy link
Member

  • Still assume Substring{String} has pointer
  • Add tests

Fixes #505

KristofferC
KristofferC reviewed Sep 16, 2024
View reviewed changes
test/parse_stream.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: JuliaSyntax parser failed — falling back to flisp!
2 participants
@LilithHafner @KristofferC