Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper for cairo_recording_surface_ink_extents() #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hustf
Copy link

@hustf hustf commented Aug 20, 2022

Ref. #355

modified: samples/Samples.md Include sample_record_inkextents
new file: samples/sample_record_inkextents.jl
new file: samples/sample_record_inkextents.png
modified: src/Cairo.jl Add ink_extents

new file:   samples/sample_record_inkextents.jl
new file:   samples/sample_record_inkextents.png
modified:   src/Cairo.jl    Add ink_extents
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #356 (5cb5ba8) into master (2b7185c) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   92.14%   92.44%   +0.30%     
==========================================
  Files           1        1              
  Lines         560      596      +36     
==========================================
+ Hits          516      551      +35     
- Misses         44       45       +1     
Impacted Files Coverage Δ
src/Cairo.jl 92.44% <100.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hustf
Copy link
Author

hustf commented Dec 13, 2022

As per @cormullion comment elsewhere: The only test so far follows the existing setup: A 'sample' file is included in 'runtests'. The test checks that an image file was produced. We could extend this to check pixel counts, but I am not sure if that would be a good test of weak points in this case. Difficult tests would include

  • large variation of scales
  • extending the canvas from positive to negative
  • drawing shapes with non-trivial bounding boxes

But in these cases, we would be testing Cairo itself, not this wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant