Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try jsasset #308

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

try jsasset #308

wants to merge 1 commit into from

Conversation

piever
Copy link
Collaborator

@piever piever commented May 12, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #308 into master will decrease coverage by 41.66%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #308       +/-   ##
===========================================
- Coverage     100%   58.33%   -41.67%     
===========================================
  Files           1        1               
  Lines           7       12        +5     
===========================================
  Hits            7        7               
- Misses          0        5        +5
Impacted Files Coverage Δ
src/Interact.jl 58.33% <0%> (-41.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc20c24...846f1ba. Read the comment docs.

@twavv
Copy link
Member

twavv commented May 18, 2019

I know I suggested this but there might actually be some issues, especially if the font awesome things are loaded before the JS (e.g. the <i class="fa fa-plane" /> is loaded before the JS finishes fetching and executing).

Maybe an alternative would just be to check if you're in a Jupyter notebook environment.

if (!(window.location.href.includes("/notebooks/") || window.location.href.includes("/lab"))) {
    // ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants