Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for erf #49

Merged
merged 4 commits into from
Aug 29, 2023
Merged

add support for erf #49

merged 4 commits into from
Aug 29, 2023

Conversation

rcalxrc08
Copy link
Contributor

solves #48

Copy link
Contributor

@mBarreau mBarreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the dependency in the folder benchmark as well.

@mBarreau
Copy link
Contributor

The manifest file must be added as well.

@rcalxrc08
Copy link
Contributor Author

Why don't you instantiate the package? Usually you don't commit the Manifest file.
Anyway I don't have julia 1.9.0, my manifest for the benchmarks is quite different from the commited one.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (41c99f4) 86.25% compared to head (2842515) 86.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   86.25%   86.30%   +0.05%     
==========================================
  Files           6        6              
  Lines         240      241       +1     
==========================================
+ Hits          207      208       +1     
  Misses         33       33              
Files Changed Coverage Δ
src/codegen.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tansongchen
Copy link
Member

The reason for committing Manifest.toml to this repo is that we want exactly the same version of dependency packages on each benchmark run, so that we can make sure the time difference from run to run is caused by a change of our performance, not others. Looks good, will merge

@tansongchen tansongchen merged commit 4bf32da into JuliaDiff:main Aug 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants