Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comparisons between tangents and numbers #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oscardssmith
Copy link
Member

useful for tests. I'm not sure whether this is a good idea, but it seems reasonable enough. @Keno

@mcabbott
Copy link
Member

mcabbott commented Jul 1, 2022

Xref #504

@mzgubic
Copy link
Member

mzgubic commented Jul 1, 2022

We removed some == methods because they were heavily invalidating #523

so it might be worth checking what the impact is here

@oscardssmith
Copy link
Member Author

oscardssmith commented Jul 1, 2022

we should definitely check in validations, but I think defining == for concrete thunk subtypes should be much better on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants