Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version limit any/all specializations #293

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 24, 2023

These don't seem necessary on recent Julia versions. On Julia version v1.9.2, using this PR, I obtain

julia> @btime any(isone, Fill(2,10000));
  2.942 ns (0 allocations: 0 bytes)

julia> @btime all(Fill(true,10000));
  2.943 ns (0 allocations: 0 bytes)

julia> @btime iszero(Eye(1000));
  1.689 ns (0 allocations: 0 bytes)

These methods are necessary mainly for infinite arrays, so the specializations should probably be added in InfiniteArrays.jl

The reason to remove the methods is that these add to method invalidation on Julia v1.10.0-beta2.

@jishnub jishnub marked this pull request as draft August 24, 2023 09:05
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #293 (a9b4d29) into master (fef31cd) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files           7        7           
  Lines         871      871           
=======================================
  Hits          870      870           
  Misses          1        1           
Files Changed Coverage Δ
src/FillArrays.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant