Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default_logger #979

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Add a default_logger #979

merged 3 commits into from
Jun 24, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented May 28, 2024

A step towards resolution of #926; see also JuliaAI/MLJ.jl#1124.

This PR:

  • Adds a global constant, initialized in __init__, for a default logger, for use with MLJFlow, for example.
  • Adds a function default_logger for returning or resetting the default logger
  • Changes the default value of the logger kwarg in evaluate, evaluate!, and Resampler from nothing to default_logger().
  • Implements MLJBase.save(mach) = MLJBase.save(default_logger(), mach) to save machines (as artifacts) at the default logger (assuming it supports this).

To do:

  • Add some tests

@ablaom ablaom marked this pull request as draft May 28, 2024 05:06
@ablaom ablaom marked this pull request as ready for review June 21, 2024 00:24
@ablaom
Copy link
Member Author

ablaom commented Jun 21, 2024

@pebeto Any chance you could review this?

@ablaom ablaom merged commit 96f691c into dev Jun 24, 2024
3 checks passed
@ablaom ablaom deleted the default-logger branch June 24, 2024 21:15
This was referenced Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants