Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing tutorials #195

Merged
merged 125 commits into from
Apr 9, 2024
Merged

Update existing tutorials #195

merged 125 commits into from
Apr 9, 2024

Conversation

EssamWisam
Copy link
Collaborator

@EssamWisam EssamWisam commented Mar 11, 2024

In this PR, tutorials will be updated to satisfy the following two conditions:

  • Run flawlessly on Julia 1.10 with the most recent package version
  • Make plots only using the default gr backend of Plots.jl (i.e., remove the Python dependency)

To do:

  • Replace Pkg.update() wth Pkg.instantiate() in tutorials
  • Fix the problems with the tutorials having a ⚠️ (now requiring only review and merge of open PR's; see the tables below)
  • Merge the new credit fraud tutorial
  • Check all tutorials render properly (e.g, no overly long outputs)

@EssamWisam
Copy link
Collaborator Author

Data Basics

Tutorial Name Changes Introduced
D0-categorical Updated manifest only
D0-dataframe Updated manifest only
D0-loading Updated manifest only
D0-processing Translated multiple plots
D0-scitype Updated manifest only

@EssamWisam
Copy link
Collaborator Author

EssamWisam commented Mar 11, 2024

Introduction to Statistical Learning

Tutorial Name Changes Introduced
ISL-lab-10 4 One-liners, 2 Plots
ISL-lab-2 1 Plot
ISL-lab-3 3 Plots Only
ISL-lab-4 4 Plots, 3 One-liners
ISL-lab-5 4 Plots Only
ISL-lab-6b 6 Plots Done but ML model output issue for last plot #200
ISL-lab-8 1 One-liner
ISL-lab-9 1 Plot Only

For some reason the lasso regressor in ISL-lab-6b after the MLJ update produces zeros for all coefficients.

@EssamWisam
Copy link
Collaborator Author

EssamWisam commented Mar 11, 2024

Getting Started

Tutorial Name Changes Introduced
A-composing-models One line
A-ensembles Fixed Plots
A-ensembles-2 One line, Fixed Plots
A-ensembles-3 Fixed Plots. Now need to fix Deterministic only. #198
A-fit-predict One line
A-learning-networks to be removed 💀 #203
A-learning-networks-2 to be removed 💀 #203
A-model-choice Updated manifest only
A-model-tuning Fixed Plots
A-stacking Fixed multiple plots. Now need to fix Deterministic only #198

I may not be able to commit the changes in the same order as in the table since I worked on multiple branches.

@EssamWisam
Copy link
Collaborator Author

EssamWisam commented Mar 11, 2024

Tutorial Name Changes Introduced
EX-GLM Two one liners
EX-airfoil Fixed one plot.
EX-boston-flux Fixed one plot.
EX-breastcancer Fixed two plots and added two one liners (not easy)
EX-horse Update manifest only
EX-housekingcounty Fixed two plots
EX-powergen Fix seven plots
EX-wine Fix one plot
EX-AMES Changed one line. Need to fix DeterministicComposite. #201
EX-boston-lgbm Stuck at an error ArgumentError: NULL library handle #201
EX-crabs-xgb Stuck at an error L1HingeLoss; edit From LossFunctions.jl, no longer supported. #201
EX-telco Fixed one line. Stuck at error ERROR: type NamedTuple has no field feature_importances #202

@EssamWisam
Copy link
Collaborator Author

I found that I didn't validate the credit-fraud tutorials because it wasn't in the horizontal nav before fix-nav was introduced. Found some minor issues and fixed.

@EssamWisam
Copy link
Collaborator Author

Found that ensembles-3 required fixes to render properly after it was moved to the advanced section (e.g., correct Project.toml reference in code) so fixed that as well.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@EssamWisam
Copy link
Collaborator Author

@ablaom Excuse me for being unprofessional in not making PRs for these changes. Point is they were deterministic and minor so I thought it's faster to get by them quickly. Don't mind any cross you see next to a commit, it implies I pushed something from __site by mistake in that commit or a previous one (which I always straightforwardly fix with a revert).

I will merge this now.

@EssamWisam EssamWisam merged commit a70e7e5 into master Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants