Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more resources #62

Merged
merged 10 commits into from
Aug 23, 2024
Merged

Add more resources #62

merged 10 commits into from
Aug 23, 2024

Conversation

calebbourg
Copy link
Collaborator

@calebbourg calebbourg commented Aug 14, 2024

Description

This PR adds APIs for the remaining resources for our initial PoC:

  • actions
  • agreements
  • overarching_goals

It also updates a few tables and uses user_ids encoded in JWTs

GitHub Issue: None

Changes

  • Add remaining resources
  • Update tables to add status and status_changed_at
  • Use user_id from JWT

Testing Strategy

tested using rapidoc

@jhodapp jhodapp added enhancement Improves existing functionality or feature feature work Specifically implementing a new feature labels Aug 14, 2024
@calebbourg calebbourg force-pushed the add_more_resources branch 2 times, most recently from 3fe982e to 776dbc7 Compare August 21, 2024 12:44
@calebbourg
Copy link
Collaborator Author

Here is the new PNG of the dbml diagram. I can never remember how to add it through the GitHub UI.

Untitled (1)

@calebbourg calebbourg marked this pull request as ready for review August 21, 2024 12:53
@jhodapp
Copy link
Member

jhodapp commented Aug 21, 2024

Here is the new PNG of the dbml diagram. I can never remember how to add it through the GitHub UI.

I'll document that here: the PNG goes into src/entity/README.md. You can edit that file from GitHub itself within your PR here and drag and drop the updated PNG onto that file at the correct line within the file. GitHub uploads the updated diagram and creates a new markdown link to the file via a URI and UUID right where your cursor is.

@calebbourg

Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor string constant updates to fix and then I'll approve this PR. This is an exciting milestone of a PR!

web/src/controller/agreement_controller.rs Outdated Show resolved Hide resolved
web/src/controller/action_controller.rs Outdated Show resolved Hide resolved
web/src/controller/overarching_goal_controller.rs Outdated Show resolved Hide resolved
web/src/controller/overarching_goal_controller.rs Outdated Show resolved Hide resolved
web/src/controller/overarching_goal_controller.rs Outdated Show resolved Hide resolved
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fabulous!

@calebbourg calebbourg merged commit 9daf850 into main Aug 23, 2024
4 checks passed
@calebbourg calebbourg deleted the add_more_resources branch August 23, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature feature work Specifically implementing a new feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants