Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle a failed DBConnection better instead of an unwrap() panic #56

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Handle a failed DBConnection better instead of an unwrap() panic #56

merged 1 commit into from
Jul 26, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Jul 26, 2024 •
edited
Loading

Description

Handle a failed DBConnection better instead of an unwrap() panic.

GitHub Issue: None

Changes

  • Handle a failed DBConnection better instead of an unwrap() panic.
  • Prints out the DBErr from SqlX and SeaORM

Testing Strategy

  1. Observe the improved error handling / error logging when you have Postgres not running
  2. Also notice that things start up as normal when Postgres is running and a connection can be made successfully

Concerns

None

@jhodapp jhodapp added bug Something isn't working enhancement Improves existing functionality or feature labels Jul 26, 2024
@jhodapp jhodapp requested review from qafui and calebbourg July 26, 2024 19:36
@jhodapp jhodapp self-assigned this Jul 26, 2024
@jhodapp jhodapp changed the title Handle a failed DBConnection better instead of an unwrap() panic. Handle a failed DBConnection better instead of an unwrap() panic Jul 26, 2024
@jhodapp jhodapp merged commit 93db113 into main Jul 26, 2024
4 checks passed
@jhodapp jhodapp deleted the improve_db_connect_fail_error_handling branch July 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qafui qafui qafui approved these changes

@calebbourg calebbourg Awaiting requested review from calebbourg

Assignees

@jhodapp jhodapp

Labels
bug Something isn't working enhancement Improves existing functionality or feature
Projects
Refactor Coaching Platform
Status: ✅ Done
Milestone
0.9 - Live update coaching session pa...
Development

Successfully merging this pull request may close these issues.
2 participants
@jhodapp @qafui