Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organizations by user #39

Merged
merged 26 commits into from
May 12, 2024
Merged

Add organizations by user #39

merged 26 commits into from
May 12, 2024

Conversation

calebbourg
Copy link
Collaborator

@calebbourg calebbourg commented Mar 19, 2024

Description

This PR updates the GET /organizations endpoint to be able to filter by a user's external_id

It also modifies the way seed data is generated to be better suited for the evolving API operations.

GitHub Issue: [Closes|Fixes|Resolves] #your GitHub issue number here

Changes

  • Allows for filtering organizations by users.external_id
  • Modifies data seeding mechanism
  • Adds extractor for authenticated user

Testing Strategy

I was able to test this against the FE using Jim-Hodapp-Coaching/refactor-platform-fe#16

@jhodapp jhodapp linked an issue Mar 19, 2024 that may be closed by this pull request
@calebbourg calebbourg force-pushed the add_organizations_by_user_id branch 2 times, most recently from fd8ae62 to f3a37ac Compare March 27, 2024 13:24
Before this change seeds were run every time we ran cargo run. This was causing
cargo run to fail if seeding had already occured. The new workflow will be to run
scripts/rebuild_db.sh && cargo run --bin seed_db && cargo run
@jhodapp jhodapp added the enhancement Improves existing functionality or feature label May 10, 2024
@calebbourg calebbourg marked this pull request as ready for review May 10, 2024 18:07
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebbourg calebbourg merged commit 168ee31 into main May 12, 2024
4 checks passed
@calebbourg calebbourg deleted the add_organizations_by_user_id branch May 12, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Get a List of a User's Organizations
2 participants