-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add organizations by user #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebbourg
force-pushed
the
add_organizations_by_user_id
branch
from
March 25, 2024 17:27
f398a15
to
c1d3557
Compare
calebbourg
force-pushed
the
add_organizations_by_user_id
branch
2 times, most recently
from
March 27, 2024 13:24
fd8ae62
to
f3a37ac
Compare
calebbourg
force-pushed
the
add_organizations_by_user_id
branch
from
March 27, 2024 13:27
f3a37ac
to
998ffc1
Compare
Before this change seeds were run every time we ran cargo run. This was causing cargo run to fail if seeding had already occured. The new workflow will be to run scripts/rebuild_db.sh && cargo run --bin seed_db && cargo run
calebbourg
force-pushed
the
add_organizations_by_user_id
branch
from
March 28, 2024 13:59
05c3ce9
to
168fc49
Compare
… --bin refactor_platform_rs
…ts the frontend from being able to log in.
…nal for the backend's use only.
…Coaching/refactor-platform-rs into add_organizations_by_user_id
jhodapp
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
GET /organizations
endpoint to be able to filter by a user'sexternal_id
It also modifies the way seed data is generated to be better suited for the evolving API operations.
GitHub Issue: [Closes|Fixes|Resolves] #your GitHub issue number here
Changes
users.external_id
Testing Strategy
I was able to test this against the FE using Jim-Hodapp-Coaching/refactor-platform-fe#16