Make sure that no notes retrieved returns an HTTP status code of 204,…

… no content

entity_api/src/note.rs

@@ -104,7 +104,27 @@ pub async fn find_by(
         }
     }
 
-    Ok(query.all(db).await?)
+    match query.all(db).await {
+        Ok(notes) => {
+            debug!("Note found: {:?}", notes);
+
+            if !notes.is_empty() {
+                Ok(notes)
+            } else {
+                Err(Error {
+                    inner: None,
+                    error_code: EntityApiErrorCode::RecordNotFound,
+                })
+            }
+        }
+        Err(err) => {
+            error!("Error encountered retrieving all notes {}", err);
+            Err(Error {
+                inner: None,
+                error_code: EntityApiErrorCode::SystemError,
+            })
+        }
+    }
 }
 
 #[cfg(test)]

web/src/controller/note_controller.rs

@@ -110,14 +110,11 @@ pub async fn index(
     debug!("GET all Notes");
     debug!("Filter Params: {:?}", params);
 
-    let coaching_sessions = NoteApi::find_by(app_state.db_conn_ref(), params).await?;
+    let notes = NoteApi::find_by(app_state.db_conn_ref(), params).await?;
 
-    debug!("Found Notes: {:?}", coaching_sessions);
+    debug!("Found Notes: {:?}", notes);
 
-    Ok(Json(ApiResponse::new(
-        StatusCode::OK.into(),
-        coaching_sessions,
-    )))
+    Ok(Json(ApiResponse::new(StatusCode::OK.into(), notes)))
 }
 
 /// GET a particular Note specified by its id.