Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agreements component and use it on the coaching sessions page #28

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Sep 13, 2024

Description

This PR adds a new component that manages listing, adding, editing and deleting agreements and uses it in the coaching sessions page.

NOTE To try out this PR, you also need this backend PR (if it hasn't been approved and merged yet).

GitHub Issue: None

Changes

  • Adds a new Next.js component that can list, add, edit and delete agreements
  • Use this component on the coaching sessions page

Screenshots / Videos Showing UI Changes:

Refactor Coaching _ Mentoring

Testing Strategy

  1. Log in and navigate to a coaching session
  2. Expand the overarching goal bar to reveal the agreements tab
  3. Add a new agreement
  4. Navigate away from this coaching session and return to it
  5. Notice that the agreement added is listed
  6. Notice that you can also add a session by clicking the "Save" button or by pressing on the keyboard
  7. Click on the "..." menu of the agreement and click "Edit"
  8. Change the agreement body
  9. Navigate away from this coaching session and return to it
  10. Notice that the updated agreement is listed
  11. Notice that you can also update a session by clicking the "Save" button or by pressing on the keyboard
  12. From the "..." menu, click "Delete" and notice that the agreement is gone from the list
  13. Navigate away from this coaching session and return to it
  14. Notice that the agreement is not listed
  15. Add several new agreements
  16. Try sorting the agreements by clicking on each column heading

Concerns

None

@jhodapp jhodapp added enhancement Improves existing functionality or feature feature work Specifically implementing a new feature labels Sep 13, 2024
@jhodapp jhodapp self-assigned this Sep 13, 2024
@jhodapp jhodapp changed the title Add agreements to the coaching session page Add agreements component and use it on the coaching sessions page Sep 22, 2024
@jhodapp jhodapp marked this pull request as ready for review September 23, 2024 01:32
Copy link
Collaborator

@qafui qafui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We're making decent progress :)

@jhodapp jhodapp merged commit ee13387 into main Sep 24, 2024
1 check passed
@jhodapp jhodapp deleted the add_agreements_to_coaching_session branch September 24, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature feature work Specifically implementing a new feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants