Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch all coaching relationships for the current user by organization id #21

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Jun 21, 2024

Description

This PR adds to the CoachingSessionSelector the ability to fetch the associated coaching relationships the current user can select from under their chosen organization.

GitHub Issue: N/A

Changes

  • Loads the associated coaching relationships in the second select after selecting an organization in the first select

Screenshots / Videos Showing UI Changes (if applicable)

Initial state:
Screenshot 2024-06-26 at 21 32 46

First selected organization:
Screenshot 2024-06-26 at 21 33 14

Second selected organization:
Screenshot 2024-06-26 at 21 33 31

Testing Strategy

  1. Log in and the dashboard will show
  2. Select an organization
  3. Notice that one list of coaching relationships loads
  4. Select a different organization
  5. Notice that a different list of coaching relationships loads

Concerns

None

…elationship in the second select box on the dashboard page
@jhodapp jhodapp self-assigned this Jun 27, 2024
@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Jun 27, 2024
@jhodapp jhodapp marked this pull request as ready for review June 27, 2024 02:36
@jhodapp jhodapp requested a review from qafui June 27, 2024 02:36
): Promise<[CoachingRelationshipWithUserNames[], string]> => {
const axios = require("axios");

var relationships: CoachingRelationshipWithUserNames[] = defaultCoachingRelationshipsWithUserNames();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of function-scoping here. :) I'd think your Rust training made the let keyword your default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why thank you. I'm influenced by Rust quite a bit. :)

@jhodapp jhodapp merged commit 0adf782 into main Jun 27, 2024
1 check passed
@jhodapp jhodapp deleted the fetch_coaching_relationship branch June 27, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants