feat(caddy): add Caddy support for Outline services #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r proxy protocol.
sbruens
changed the title
sbruens
commented
Sep 20, 2024
| ) | ||
|
|
||
| func (OutlineApp) CaddyModule() caddy.ModuleInfo { | ||
| return caddy.ModuleInfo{ID: outlineModuleName} |
There was a problem hiding this comment.
Note we still need to provide a ModuleInfo with an accurate ID, so there is some duplication here now, but New() isn't used from it as far as I can tell. This is also why I'm not logging any errors here, since it is called and used in a few places.
There was a problem hiding this comment.
That's unfortunate. At least we don't have the two module objects co-existing anymore. Thanks for the changes.
fortuna
approved these changes
Sep 20, 2024
| ) | ||
|
|
||
| func (OutlineApp) CaddyModule() caddy.ModuleInfo { | ||
| return caddy.ModuleInfo{ID: outlineModuleName} |
There was a problem hiding this comment.
That's unfortunate. At least we don't have the two module objects co-existing anymore. Thanks for the changes.
…don't need a zap adapter for Caddy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proof of concept lays the foundation for integrating Outline service support into Caddy through the implementation of two new Caddy modules:
outlineHost Module: This module serves as the central hub for server-wide configuration settings related to the Outline service. It also handles the configuration of application-level metrics, ensuring we can monitor the service's performance effectively.shadowsocksLayer4 App Guest Module: This module introduces a specialized handler to manage both stream-based and packet-based Shadowsocks connections. It operates in conjunction with the outline host module, utilizing its shared configuration settings.Note:
While this PR establishes the core functionality, there are outstanding tasks related to metrics that might be addressed in separate PRs for better organization and focus:
shadowsocks_prefix, particularly for server-wide metrics like{PREFIX}_build_info, and{PREFIX}_ports, which aren't specifically tied to Shadowsocks.outlinemodule.{PREFIX}_keysand{PREFIX_ports}metrics in this Caddy implementation.