feat(server): add an experimental opt-in API to enable ASN metrics #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
commented
Mar 21, 2024
fortuna
requested changes
Mar 22, 2024
fortuna
approved these changes
Mar 25, 2024
|
Cut a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP-to-ASN database is provided to
outline-ss-serverat server startup instead of via the server config, so here we SIGTERM the process for restart when the ASN metric is enabled. Since this is only ever meant to be an experimental API, that is probably ok. We can always move it to the server config if we want to graduate the endpoint to be a stable API.