Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/windows): restore product name to "Outline" #2214

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Sep 20, 2024

This commit reverts the product name from "outline-client" back to "Outline".

This also fixed the reinstallation issue. Though I'm still not sure about the root cause, it could be that electron-builder failed to handle the '-' character (similar to electron-userland/electron-builder#6488, but not exactly the same).

@jyyi1 jyyi1 requested a review from a team as a code owner September 20, 2024 22:47
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@jyyi1 jyyi1 merged commit 564e858 into master Sep 24, 2024
23 checks passed
@jyyi1 jyyi1 deleted the junyi/fix-windows-product-name branch September 24, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants