feat(client): disable TCP Keep-Alive to save battery #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
approved these changes
Apr 24, 2024
jyyi1
reviewed
Apr 24, 2024
outline/device/stream_dialer.go
Outdated
| "github.com/Jigsaw-Code/outline-sdk/transport" | ||
| "github.com/Jigsaw-Code/outline-sdk/transport/shadowsocks" | ||
| ) | ||
|
|
||
| // newOutlineStreamDialer creates a [transport.StreamDialer] that connects to the remote proxy using `config`. | ||
| func newOutlineStreamDialer(config *transportConfig) (transport.StreamDialer, error) { | ||
| dialer, err := shadowsocks.NewStreamDialer(&transport.TCPEndpoint{Address: config.RemoteAddress}, config.CryptoKey) | ||
| // We disable Keep-Alive as per https://datatracker.ietf.org/doc/html/rfc1122#page-101, which states that it should only be |
There was a problem hiding this comment.
I remembered we should have already removed all code from outline/device? #1972
There was a problem hiding this comment.
Oh, I was on an outdated master. Updated.
fortuna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the client-side of Jigsaw-Code/outline-ss-server#108
We should probably also reduce the duration on the server-side.